Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16868 bio: Skip LED reset on absent bdev #15718

Merged
merged 1 commit into from
Jan 14, 2025
Merged

DAOS-16868 bio: Skip LED reset on absent bdev #15718

merged 1 commit into from
Jan 14, 2025

Conversation

tanabarr
Copy link
Contributor

@tanabarr tanabarr commented Jan 11, 2025 •
edited
Loading

Don't fail if bdev isn't accessible and won't return address when
attempting to reset LED state.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@tanabarr tanabarr self-assigned this Jan 11, 2025
@tanabarr tanabarr requested review from a team as code owners January 11, 2025 00:55
@github-actions GitHub Actions
Copy link

Errors are Unable to load ticket data
https://daosio.atlassian.net/browse/DAOS-16868

@tanabarr tanabarr requested review from kjacque and knard38 January 11, 2025 00:55
knard38
knard38 approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@knard38 knard38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, one minor remark

src/bio/bio_device.c
@@ -794,11 +795,7 @@ set_timer_and_check_faulty(struct bio_xs_context *xs_ctxt, struct spdk_pci_addr
if (dev_info->bdi_traddr == NULL) {
D_ERROR("No transport address for dev:"DF_UUID", unable to verify state\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT, a warning error level message could be more suited ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will change this in a future update, thanks

@tanabarr tanabarr requested a review from a team January 14, 2025 14:24
@tanabarr tanabarr added the bug label Jan 14, 2025
@daltonbohning daltonbohning merged commit 7c0d665 into master Jan 14, 2025
62 checks passed
@daltonbohning daltonbohning deleted the tanabarr/bio-start-with-bad-dev branch January 14, 2025 15:52
tanabarr added a commit that referenced this pull request Jan 14, 2025
@tanabarr
DAOS-16868 bio: Skip LED reset on absent bdev (#15718)
d38853c 
Signed-off-by: Tom Nabarro <[email protected]>
daltonbohning pushed a commit that referenced this pull request Jan 15, 2025
@tanabarr
DAOS-16868 bio: Skip LED reset on absent bdev (#15718) (#15733)
9a1b410 
Signed-off-by: Tom Nabarro <[email protected]>
This was referenced Jan 22, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knard38 knard38 knard38 approved these changes

@kjacque kjacque kjacque approved these changes

Assignees

@tanabarr tanabarr

Labels
bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tanabarr @kjacque @knard38 @daltonbohning