Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-4753 test: Initial tests for validating multiple ranks. #15788

Draft
wants to merge 6 commits into
base: tanabarr/control-drainpool-multirank
Choose a base branch
from
Draft

DAOS-4753 test: Initial tests for validating multiple ranks. #15788

wants to merge 6 commits into from

Conversation

rpadma2
Copy link
Contributor

@rpadma2 rpadma2 commented Jan 24, 2025

Test-tag: test_osa_online_drain_with_multiple_ranks test_osa_offline_drain_with_multiple_ranks
Skip-unit-tests: true

Summary:

  • Add new OSA tests to validate multiple ranks support via dmg commands.
  • Updates are done for drain and reintegration tests (offline/online)

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@rpadma2
DAOS-4753 test: Initial tests for validating multiple ranks.
577695e 
Test-tag: test_osa_online_drain_with_multiple_ranks test_osa_offline_drain_with_multiple_ranks
Skip-unit-tests: true

Summary:
- Add new OSA tests to validate multiple ranks support via dmg commands.
- Updates are done for drain and reintegration tests (offline/online)

Signed-off-by: rpadma2 <[email protected]>
@rpadma2 rpadma2 requested review from a team as code owners January 24, 2025 19:54
@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15788/1/execution/node/339/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15788/1/execution/node/322/log

@daosbuild1
Copy link
Collaborator

Test stage Build on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15788/1/execution/node/414/log

daltonbohning
daltonbohning requested changes Jan 24, 2025
View reviewed changes
utils/githooks/hook_base.sh
@@ -1,6 +1,7 @@
#!/bin/bash
#!/usr/bin/env bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you cherry-pick other changes to this commit?

src/tests/ftest/osa/offline_drain.py Show resolved Hide resolved
src/tests/ftest/osa/offline_drain.py Outdated
:avocado: tags=OSAOfflineDrain,test_osa_offline_drain_with_multiple_ranks
"""
self.log.info("Offline Drain : Test with mutiple ranks")
self.test_with_multiple_ranks = self.params.get("test_with_multiple_ranks",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really have to stop setting class variables like this and instead pass as arguments to the appropriate functions. Doing this makes it extremely difficult to debug/refactor/make changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. will definitely consider this change.

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.5 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15788/1/execution/node/342/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15788/1/execution/node/345/log

@github-actions GitHub Actions
Copy link

Ticket title is 'OSA : Batch servers (reintegration, drain).'
Status is 'In Progress'
Labels: 'Drain,Online_Reintegration,SRS-12-0268,SRS-12-0269,testp2'
https://daosio.atlassian.net/browse/DAOS-4753

@daosbuild1
Copy link
Collaborator

Test stage Build on Leap 15.5 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15788/1/execution/node/507/log

@rpadma2
DAOS-4753 test: Updates to online_dran.py
f1c555e 
Test-tag: test_osa_online_drain_with_multiple_ranks test_osa_offline_drain_with_multiple_ranks
Skip-unit-tests: true

Signed-off-by: rpadma2 <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Build on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15788/2/execution/node/334/log

@daosbuild1
Copy link
Collaborator

Test stage Build on Leap 15.5 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15788/2/execution/node/349/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15788/2/execution/node/327/log

@rpadma2
DAOS-4753 test: Address end of line issue.
ea1457d 
Test-tag: test_osa_online_drain_with_multiple_ranks test_osa_offline_drain_with_multiple_ranks
Skip-unit-tests: true

Signed-off-by: rpadma2 <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Build on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15788/3/execution/node/370/log

@daosbuild1
Copy link
Collaborator

Test stage Build on Leap 15.5 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15788/3/execution/node/376/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15788/3/execution/node/317/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15788/3/execution/node/359/log

@rpadma2 rpadma2 marked this pull request as draft January 24, 2025 20:41
@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.5 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15788/3/execution/node/360/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15788/3/execution/node/320/log

@rpadma2
DAOS-4753 test: Pass multiple ranks as parameter
60302db 
Test-tag: test_osa_online_drain_with_multiple_ranks test_osa_offline_drain_with_multiple_ranks
Skip-unit-tests: true

Signed-off-by: rpadma2 <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Python Bandit check completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15788/4/execution/node/133/log

@rpadma2
DAOS-4753 test: Update osa_utils.py format.
2165436 
Test-tag: test_osa_online_drain_with_multiple_ranks test_osa_offline_drain_with_multiple_ranks
Skip-unit-tests: true

Signed-off-by: rpadma2 <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Build on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15788/5/execution/node/335/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15788/5/execution/node/320/log

@daosbuild1
Copy link
Collaborator

Test stage Build on Leap 15.5 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15788/5/execution/node/429/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15788/5/execution/node/317/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15788/5/execution/node/387/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.5 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15788/5/execution/node/384/log

@rpadma2
DAOS-4753 test: Fix pylint issues and add reintegration tests.
9f6d40d 
Test-tag: test_osa_online_drain_with_multiple_ranks test_osa_offline_drain_with_multiple_ranks test_osa_online_reintegration_with_multiple_ranks test_osa_offline_reintegrate_with_multiple_ranks
Skip-unit-tests: true

Signed-off-by: rpadma2 <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Build on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15788/6/execution/node/370/log

@daosbuild1
Copy link
Collaborator

Test stage Build on Leap 15.5 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15788/6/execution/node/375/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15788/6/execution/node/347/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15788/6/execution/node/351/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.5 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15788/6/execution/node/354/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15788/6/execution/node/314/log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daltonbohning daltonbohning daltonbohning requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rpadma2 @daosbuild1 @daltonbohning