Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates for scikit-learn 1.2.0 #959

Merged
merged 5 commits into from
Feb 3, 2023
Merged

Conversation

mmccarty
Copy link
Member

@mmccarty mmccarty commented Jan 13, 2023

  • Update tests and code to handle scikit-learn==1.2.0 deprecation warnings
  • Update environment files
  • Update package requirements

@mmccarty mmccarty marked this pull request as ready for review January 13, 2023 20:47
@mmccarty
Copy link
Member Author

Ready for review @jrbourbeau cc @betatim

dask_ml/cluster/k_means.py Outdated Show resolved Hide resolved
dask_ml/cluster/k_means.py Outdated Show resolved Hide resolved
@betatim
Copy link

betatim commented Jan 18, 2023

The changes looks reasonable to me. Only question I have is regarding backwards compatibility and such. Does dask-ml make promises about changes of parameter default values?

@mmccarty
Copy link
Member Author

mmccarty commented Jan 18, 2023

The changes looks reasonable to me. Only question I have is regarding backwards compatibility and such. Does dask-ml make promises about changes of parameter default values?

No promises that I'm aware of. From my experience, the project seems to follow scikit-learn for API changes. I don't intend on adding backwards compatibility with older versions of scikit-learn in this PR. Others are welcome to follow up.

@TomAugspurger
Copy link
Member

TomAugspurger commented Jan 18, 2023 via email

@mmccarty
Copy link
Member Author

I'm not opposed to this. #957 requires 1.1.3 and is merged. Added #961 to track.

@mmccarty
Copy link
Member Author

mmccarty commented Feb 2, 2023

@jrbourbeau - Any comments here?

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delayed response. I've not had a change to look at the changes here yet and probably won't be able to get to it for a bit. If you and @betatim are happy with the changes here, I'd recommend moving forward with them. No need to block on me

@betatim
Copy link

betatim commented Feb 3, 2023

Let's merge this then. I would have clicked the button, but I can't :D

@mmccarty mmccarty merged commit ba2024d into dask:main Feb 3, 2023
@mmccarty mmccarty deleted the sklearn-1.2.0 branch March 12, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants