-
-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates for scikit-learn 1.2.0 #959
Conversation
Ready for review @jrbourbeau cc @betatim |
Co-authored-by: Tim Head <[email protected]>
Co-authored-by: Tim Head <[email protected]>
The changes looks reasonable to me. Only question I have is regarding backwards compatibility and such. Does dask-ml make promises about changes of parameter default values? |
No promises that I'm aware of. From my experience, the project seems to follow scikit-learn for API changes. I don't intend on adding backwards compatibility with older versions of scikit-learn in this PR. Others are welcome to follow up. |
In general, my policy was to match the lowest-supported version of
scikit-learn, but to pretty aggressively bump that minimum supported
version when it became at all challenging to support both versions. If
pople are able to upgrade their version of scikit-learn to the latest, then
they ought to be able to upgrade dask-ml as well (and vice-versa).
…On Wed, Jan 18, 2023 at 8:48 AM Mike McCarty ***@***.***> wrote:
The changes looks reasonable to me. Only question I have is regarding
backwards compatibility and such. Does dask-ml make promises about changes
of parameter default values?
No promises that I'm aware of. From my experience, the project seems to
follow scikit-learn for API changes. I don't intend on adding backwards
compatibility with older version of scikit-learn in this PR. Others are
welcome to follow up.
—
Reply to this email directly, view it on GitHub
<#959 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKAOIRSBU7KNZI3DKIRV7LWS77EFANCNFSM6AAAAAAT2XZ5IM>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
@jrbourbeau - Any comments here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the delayed response. I've not had a change to look at the changes here yet and probably won't be able to get to it for a bit. If you and @betatim are happy with the changes here, I'd recommend moving forward with them. No need to block on me
Let's merge this then. I would have clicked the button, but I can't :D |
scikit-learn==1.2.0
deprecation warnings