Generate 3d float matrix #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcannood
approved these changes
Jan 17, 2025
|
If the only thing you want to check is the 3 dimensions, I didn't want to further clutter the object. But thinking back on this, this seems counter to the philosophy of the rest of this package. However, we do need to limit ourselves in some ways. Do you think there's a need to go beyond 3 dimensions? |
|
I don't think there is really a need to go beyond 3 dimensions, though in the spirit of the package you could try a (10, 9, 8, 7, 6, 5)-dimensional sparse matrix :p I'd be inclined to at least add integer matrices as well; boolean and string are nice to haves. Would you like this one merged already? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
float_matrix_3das a matrix generator. Closes #15