Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a sanity check for fastqc being installed #210

Merged
merged 2 commits into from
Jan 30, 2020

Conversation

tejashree1modak
Copy link

Submitting a pull request for issue - #209

@fpsom
Copy link
Contributor

fpsom commented Jan 28, 2020

Thanks @tejashree1modak - that is indeed a useful check.

If possible, could you update the PR, so that it also includes the output of the command fastqc -h (given that it's correctly installed)? For me, this would be a more complete representation of the expected possibilities.

@tejashree1modak
Copy link
Author

Thanks @tejashree1modak - that is indeed a useful check.

If possible, could you update the PR, so that it also includes the output of the command fastqc -h (given that it's correctly installed)? For me, this would be a more complete representation of the expected possibilities.

@fpsom I agree. I have updated the PR accordingly. Pl take a look. Thanks

@fpsom
Copy link
Contributor

fpsom commented Jan 30, 2020

Thanks @tejashree1modak ! LGTM!

@fpsom fpsom merged commit 0c72838 into datacarpentry:gh-pages Jan 30, 2020
zkamvar pushed a commit that referenced this pull request May 4, 2023
Adding a sanity check for fastqc being installed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants