Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pdp] Refine prep modeling dataset template nb #60

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

bdewilde
Copy link
Member

@bdewilde bdewilde commented Jan 25, 2025

changes

updates pdp prep modeling dataset template nb to leverage new project configs, work for both "train" and "predict" runs, and adds more instruction wrt action items

context

trying to standardize the full pipeline, leverage project configs, and make everything work in both training and prediction runs

a subset of changes in PR #55, broken out for reviewability
sibling to PR #59

questions

  • I've moved feature selection out of this step of the pipeline. For multiple reasons (I can elaborate), this works better and more safely alongside model training. Any strong objections to this?

@bdewilde bdewilde changed the title [pdp] Refine prep modeling dataset emplate nb [pdp] Refine prep modeling dataset template nb Jan 25, 2025
@bdewilde bdewilde marked this pull request as ready for review January 25, 2025 19:48
@bdewilde bdewilde requested a review from nm3224 January 25, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant