-
Notifications
You must be signed in to change notification settings - Fork 3
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
A hatch-based environment (`types`) is added. Locally, hatch users can run ``` hatch run types:check ``` to get the checked out code type-checked. Additionally, two workflows are added that test for typing issues. One (`mypy-pr`) only tests files that changed in a PR. The other (`mypy-project`) tests all code. The rational for having two separate tests is that individual PRs should not be blocked by typing issues that appear in the rest of the code base. This can happen when changes are forced into the mainline, or conditions change between (Python) versions.
- Loading branch information
Showing
4 changed files
with
103 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
name: Type annotation (PR) | ||
|
||
on: | ||
pull_request: | ||
paths: | ||
- 'datalad_core/**.py' | ||
- '!**/tests/**.py' | ||
|
||
jobs: | ||
check: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Setup Python | ||
uses: actions/setup-python@v5 | ||
with: | ||
# run on a "fresh" python, but see mypy flag to check for the oldest supported version | ||
python-version: 3.12 | ||
architecture: x64 | ||
- name: Checkout | ||
uses: actions/checkout@v4 | ||
- name: Install hatch (which pull mypy) | ||
run: python -m pip install hatch | ||
- name: Get Python changed files | ||
id: changed-py-files | ||
uses: tj-actions/changed-files@v44 | ||
with: | ||
files: | | ||
*.py | ||
**/*.py | ||
- name: Type check changed files | ||
if: steps.changed-py-files.outputs.any_changed == 'true' | ||
run: | | ||
# get any type stubs that mypy thinks it needs | ||
hatch run types:mypy --install-types --non-interactive --follow-imports skip ${{ steps.changed-py-files.outputs.all_changed_files }} | ||
# run mypy on the modified files only, and do not even follow imports. | ||
# this results is a fairly superficial test, but given the overall | ||
# state of annotations, we strive to become more correct incrementally | ||
# with focused error reports, rather than barfing a huge complaint | ||
# that is unrelated to the changeset someone has been working on. | ||
# run on the oldest supported Python version | ||
hatch run types:mypy --python-version 3.9 --follow-imports skip --pretty --show-error-context ${{ steps.changed-py-files.outputs.all_changed_files }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
name: Type annotation (project) | ||
|
||
on: | ||
push: | ||
paths: | ||
- 'datalad_core/**.py' | ||
- '!**/tests/**.py' | ||
|
||
jobs: | ||
check: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Setup Python | ||
uses: actions/setup-python@v5 | ||
with: | ||
# run on a "fresh" python, but see mypy flag to check for the oldest supported version | ||
python-version: 3.12 | ||
architecture: x64 | ||
- name: Checkout | ||
uses: actions/checkout@v4 | ||
- name: Install hatch (which pull mypy) | ||
run: python -m pip install hatch | ||
- name: Type check project | ||
run: | | ||
# get any type stubs that mypy thinks it needs | ||
hatch run types:mypy --install-types --non-interactive --follow-imports skip datalad_core | ||
# run mypy on the full project. | ||
# run on the oldest supported Python version | ||
hatch run types:mypy --python-version 3.9 --pretty --show-error-context datalad_core |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
from __future__ import annotations |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters