Additional bits towards to first command implementations #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mih
force-pushed
the
create
branch
2 times, most recently
from
6b5332e to
36e900a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 52 54 +2
Lines 2202 2333 +131
Branches 146 162 +16
==========================================
+ Hits 2202 2333 +131 ☔ View full report in Codecov by Sentry. |
This duo of constraints has a key role for resolving paths with and without an optional dataset context. In legacy DataLad, a similar role was filled by a set of helper functions (e.g., `require_dataset()`, and `resolve_path()`). These are no migrated, because of the complex interdependencies. I envision for them to be entirely replaced by these two constraints. The next commit will have dedicated documentation on the targeted implementation pattern.
This aims to illustrate the necessary boilerplate to add the conventional DataLad path resolution behavior to a command. Importantly, this is done completely outside the implementation of the actual command. It is all parameterization of the `@datalad_command` decorator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.