Helpers #35
Merged
Helpers #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a poor-man's datalad-save. We use this instead, because we do not actually want to have the inner workings of the tests depend on the very core of the functionality they are supposed to test. This helper merely calls git-add and git-commit in direct succession. For most practical applications is can immediately replace datalad-save, and it is faster.
The fixtures - `symlinks_supported` - `skip_when_symlinks_not_supported` simplified test implementations that needs to behave differently (or not at all) when symlinks are not available on the filesystem the tests are using.
This is a more flexible and more robust variant of the datalad-next fixture `modified_dataset`, split into a test helper and the actual fixture. Unlike the datalad-next version, it does not require any datalad commands to work, just plain Git.
This is no more than a wrapper around `shutil.rmtree()`, but with an error handler that tries to set write permissions on error. This is a common-enough fix needed on the windows platform that it seems worth providing a helper for. Legacy DataLad also has one, but it's implementation seems to be very much stuck in Python 2 times.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
===========================================
- Coverage 100.00% 99.22% -0.78%
===========================================
Files 54 58 +4
Lines 2335 2447 +112
Branches 162 175 +13
===========================================
+ Hits 2335 2428 +93
- Misses 0 15 +15
- Partials 0 4 +4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The drop in coverage will be temporary. It is mostly caused by the fixtures that will be used heavily in the next PR.