Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve type-checking of imports #179

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Improve type-checking of imports #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ console_scripts =
datalad-installer = datalad_installer:main

[mypy]
ignore_missing_imports = True
ignore_missing_imports = False
disallow_untyped_defs = True
disallow_incomplete_defs = True
no_implicit_optional = True
Expand Down
1 change: 1 addition & 0 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ commands =
[testenv:typing]
deps =
mypy
{[testenv]deps}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not familiar with this syntax, could you please digest it for me?

Copy link
Member Author

@jwodder jwodder Nov 8, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is tox-specific syntax that causes all deps listed in the [testenv] environment (i.e., all of our test dependencies) to be included in the deps for the typing environment. This is necessary for mypy to be able to type-check test code that uses dependencies like pytest.

commands =
mypy src test

Expand Down
Loading