Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruff linter action #6

Merged
merged 1 commit into from
May 14, 2024
Merged

Add Ruff linter action #6

merged 1 commit into from
May 14, 2024

Conversation

mih
Copy link
Member

@mih mih commented May 14, 2024

Easy to turn off when it becomes too annoying. But it is only simple to introduce right now.

Closes #2

Copy link

codeclimate bot commented May 14, 2024

Code Climate has analyzed commit f8f57a5 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 40.00%. Comparing base (ba02869) to head (f8f57a5).
Report is 2 commits behind head on main.

❗ Current head f8f57a5 differs from pull request most recent head d61694f. Consider uploading reports for the commit d61694f to get more accurate results

Files Patch % Lines
datasalad/dummy.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main       #6       +/-   ##
===========================================
- Coverage   50.00%   40.00%   -10.00%     
===========================================
  Files           2        2               
  Lines           4        5        +1     
===========================================
  Hits            2        2               
- Misses          2        3        +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mih mih merged commit b1ca700 into main May 14, 2024
5 checks passed
@mih mih deleted the ruff branch May 14, 2024 18:59
@mslw
Copy link
Contributor

mslw commented May 15, 2024

I wanted to add a post-hoc comment that I like the idea. I've heard of ruff before and it may be interesting to see how it works in practice.

It wasn't clear to me at the beginning, but it became clear with a very quick search, that:

  • the ruff action is a pass/fail test
  • ruff's formatting defaults are black-compatible, meaning e.g. 88 character line width (which I like over the traditional 80)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Policy Q: Adopt a linter/formatter?
3 participants