[ #60 , extract tasks ] #71
Conversation
🦋 Changeset detectedLatest commit: e1923b3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| MddbFileTag, | ||
| File, | ||
| } from "./schema.js"; | ||
| import { MddbFile, MddbTag, MddbLink, MddbFileTag, File } from "./schema.js"; |
There was a problem hiding this comment.
For me this "linting" stuff creates noise in the PRs. I strongly suggest we do this separately (it can just be a direct push to main if just linting).
There was a problem hiding this comment.
Sure thing. The only thing that makes me lint on PR is our ci/cd complaining, but I will select the Github option to bypass this error.
There was a problem hiding this comment.
For future: we can lint the whole repo once and then we don't get running into these.
| @@ -6,3 +6,9 @@ tags: tag1, tag2, tag3 | |||
| # Welcome | |||
|
|
|||
| [link](blog0.mdx) | |||
|
|
|||
| - [] uncompleted task 1 | |||
There was a problem hiding this comment.
Surely we need a pure list item ... which is not a task and check it is not showing up in our tasks list ...
We are in theory extracting tasks not just all list items
i.e. something like ...
- this is a list item
- this is another list itemThere was a problem hiding this comment.
Yes, of course, I tested for those before committing.
Actually, this exact line - [] uncompleted task 1 is a list item that's not being identified as a task because it's [] and not [ ], i.e., missing a space between the brackets, thus not a valid task (not valid in Obsidian, Github markdown, or even remark-parse).
There was a problem hiding this comment.
@mohamedsalem401 ok that wasn't obvious because of the name. 😄
| const nodes = selectAll("*", ast); | ||
| const tasks: Task[] = []; | ||
| nodes.map((node: any) => { | ||
| if (node.type === "listItem") { |
There was a problem hiding this comment.
This looks like we will extract all list items as tasks which is not correct ....
src/lib/parseFile.ts
Outdated
| if (node.type === "listItem") { | ||
| const description = recursivelyExtractText(node).trim(); | ||
| const checked = node.checked; | ||
| if (checked !== null) { |
There was a problem hiding this comment.
@rufuspollock
You are right; we need to exclude listItems that are not tasks. That's why I am checking if checked is null to exclude the non-tasks list items, as per the documentation for GFM.
| MddbFileTag, | ||
| File, | ||
| } from "./schema.js"; | ||
| import { MddbFile, MddbTag, MddbLink, MddbFileTag, File } from "./schema.js"; |
There was a problem hiding this comment.
For future: we can lint the whole repo once and then we don't get running into these.
Issue #60 - Extract Tasks
Description:
Adding a new feature for extracting tasks from Markdown format strings.
Changes:
- [ ] task- [x] taskand- [X] task