Allow more than two of the same ID for TOC #209

dauxio · Jun 5, 2020 · d556536 · d556536
1 parent 6ebdc15
commit d556536
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/libs/Format/HTML/ContentTypes/Markdown/TOC/Processor.php b/libs/Format/HTML/ContentTypes/Markdown/TOC/Processor.php
@@ -86,6 +86,8 @@ protected function getUniqueId(Document $document, $proposed)
             ++$extension;
         } while (in_array("$proposed-$extension", $document->heading_ids));
 
+        $document->heading_ids[] = "$proposed-$extension";
+
         return "$proposed-$extension";
     }
 

diff --git a/tests/Format/HTML/TableOfContentsTest.php b/tests/Format/HTML/TableOfContentsTest.php
@@ -81,7 +81,7 @@ public function testDuplicatedTOC()
     {
         $converter = new CommonMarkConverter($this->getConfig());
 
-        $source = "[TOC]\n# Test\n# Test";
+        $source = "[TOC]\n# Test\n# Test\n# Test";
         $expected = <<<'EXPECTED'
 <ul class="TableOfContents">
 <li>
@@ -90,9 +90,13 @@ public function testDuplicatedTOC()
 <li>
 <p><a href="#page_Test-2">Test</a></p>
 </li>
+<li>
+<p><a href="#page_Test-3">Test</a></p>
+</li>
 </ul>
 <h1 id="page_Test">Test</h1>
 <h1 id="page_Test-2">Test</h1>
+<h1 id="page_Test-3">Test</h1>
 
 EXPECTED;