New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix token auth when `service` is missing #58

Open

jvstme wants to merge 1 commit into davedoesdev:master from jvstme:service-optional

jvstme commented Oct 15, 2024

Make the service parameter optional, since some registries do not use it. The same logic can be found in containerd.

Fixes #57


          Fix token auth when service is missing

296e008

Make the `service` parameter optional when
fetching a bearer token, since some registries do
not use it.

The same logic can be found in containerd:
https://github.com/containerd/containerd/blob/61f91b963ef244daec1bda6700fe3f0b1aee50c6/core/remotes/docker/auth/fetch.go#L187

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet