Fix: do not unfurl bot events.

dblock · Nov 29, 2024 · 441863a · 441863a
1 parent f331f4b
commit 441863a
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/slack-strava/api/endpoints/requests/event.rb b/slack-strava/api/endpoints/requests/event.rb
@@ -33,6 +33,7 @@ def user
 
         def unfurl!
           return unless event&.links && user
+          return if user.is_bot
 
           event.links.each do |link|
             next unless link.domain == 'strava.com'

diff --git a/spec/api/endpoints/slack_endpoint_spec.rb b/spec/api/endpoints/slack_endpoint_spec.rb
@@ -516,6 +516,19 @@
             expect(last_response.status).to eq 201
           end
         end
+
+        context 'with a bot user' do
+          before do
+            user.update_attributes!(is_bot: true)
+          end
+
+          it 'does not unfurl' do
+            expect_any_instance_of(User).not_to receive(:sync_strava_activity!)
+            expect_any_instance_of(Slack::Web::Client).not_to receive(:chat_unfurl)
+            post '/api/slack/event', payload
+            expect(last_response.status).to eq 201
+          end
+        end
       end
     end
   end