Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dfuzzer.conf: suppress org.freedesktop.login1.Sleep() #140

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

mrc0mmand
Copy link
Member

Introduced in systemd/systemd#29853.

@evverx
Copy link
Member

evverx commented Jan 29, 2024

I think it would be great if it was possible to skip destructive methods when dfuzzer is privileged enough to actually call them and call them when it's unprivileged. It should make it possible to poke all those polkit/dbus rules.

@mrc0mmand
Copy link
Member Author

I think it would be great if it was possible to skip destructive methods when dfuzzer is privileged enough to actually call them and call them when it's unprivileged. It should make it possible to poke all those polkit/dbus rules.

I guess something like that would make sense, but we'd need a way to mark certain functions unsafe even for that mode, since they're potentially unsafe even when run unprivileged. For example, the org.freedesktop.login1.Manager interface has TerminateUser() function, which, when unprivileged, is still able to kill the current user's session:

[vagrant@centos9s ~]$ busctl call org.freedesktop.login1 /org/freedesktop/login1 org.freedesktop.login1.Manager TerminateUser u 0
Call failed: Interactive authentication required.
[vagrant@centos9s ~]$ busctl call org.freedesktop.login1 /org/freedesktop/login1 org.freedesktop.login1.Manager TerminateUser u 1000
Connection to 192.168.122.124 closed by remote host.

@mrc0mmand mrc0mmand merged commit fe98ba9 into dbus-fuzzer:master Jan 29, 2024
19 checks passed
@mrc0mmand mrc0mmand deleted the suppress-login-sleep branch January 29, 2024 15:01
@evverx
Copy link
Member

evverx commented Jan 29, 2024

we'd need a way to mark certain functions unsafe even for that mode

Makes sense. Maybe something like the TotallyDestructive mode could cover those.

Though from time to time it would be nice to ignore them too. systemd/systemd#30917 was triggerred by dfuzzer as far as I can remember. It can probably be done by generating a new config where methods like that aren't included at all. Dunno.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants