Use run() instead of tick() #697
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
run() is more efficiently and spawns a local task queue for efficiency. As opposed to tick(), which only polls the global queue. Signed-off-by: John Nunley <[email protected]>
zeenix
reviewed
Mar 30, 2024
| while !executor.is_empty() { | ||
| executor.tick().await; | ||
| } | ||
| executor.run(Empty(&executor)).await |
There was a problem hiding this comment.
executor running a dummy future, to run itself seems very weird. I understood from your comment here that you intend to make tick also more efficient, so maybe we just wait for that? It all depends on how much efficiency and under which scenarios would it be significant enough to justify sacrificing code readability and many Future impls.
|
Good point |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run() is more efficiently and spawns a local task queue for efficiency. As opposed to tick(), which only polls the global queue.