Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vietnam War factions for USA and NVA #3245

Merged
merged 5 commits into from
Nov 18, 2023

Conversation

Starfire13
Copy link
Contributor

This adds factions for Vietnam War for both the US and North Vietnamese Army.

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b73ca2c) 46.10% compared to head (04f82b1) 46.10%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3245   +/-   ##
========================================
  Coverage    46.10%   46.10%           
========================================
  Files          474      474           
  Lines        26025    26025           
  Branches      4527     4527           
========================================
  Hits         12000    12000           
  Misses       14004    14004           
  Partials        21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Remove Cold War Flak from USA 1970 as it was allowing the faction to use the S-60 57mm
@DanAlbert DanAlbert force-pushed the vietnam_war_factions branch from 97b89dc to 04f82b1 Compare November 18, 2023 22:08
@DanAlbert DanAlbert merged commit c4e2e45 into dcs-liberation:develop Nov 18, 2023
7 checks passed
@Starfire13 Starfire13 deleted the vietnam_war_factions branch December 4, 2023 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants