Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added build for mac arm #10

Merged
merged 2 commits into from
Aug 14, 2024
Merged

feat: added build for mac arm #10

merged 2 commits into from
Aug 14, 2024

Conversation

Antabuse-123
Copy link
Contributor

No description provided.

Copy link
Contributor

@AngheloAlf AngheloAlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!
Sadly I don't have an ARM Mac machine so I can't test this myself.
Could you tell me how did you test this?

Also, you may want to apply this change to the companion binutils repo too: https://github.com/decompals/mips-binutils-2.6

HOST: 'i386-apple-darwin',
ARCHIVE_NAME: 'gcc-2.7.2-mac.tar.gz'
}
- {
OS: 'macos-latest',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the github actions runner repo (https://github.com/actions/runner-images?tab=readme-ov-file#available-images) seems like the meaning of macos-latest has shifted to an arm machine.
It would be better to pin the images we use to avoid confusion, so what about using macos-14 here?

Suggested change
OS: 'macos-latest',
OS: 'macos-14',

@Antabuse-123
Copy link
Contributor Author

Antabuse-123 commented Aug 14, 2024

Hello,

So I changed the version number as you suggested.
Sadly, I did not run any test with the binaries but they are compiling just fine. That's why I wanted to add this workflow.

EDIT: If this is ok for you to merge, I could add this feature in the other repo that you mentionned of course

@AngheloAlf AngheloAlf merged commit 43d1cdb into decompals:main Aug 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants