Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap out default Invidious instances #136

Merged
merged 1 commit into from
Oct 7, 2020

Conversation

nchristensen
Copy link

The invidio.us server longer runs so MusicPiped is broken at present. This change is simply a string replacement of invidio.us to invidious.snopyta.org. I'm not an Android developer so I don't have the tools set up to test it.

@Kerosel
Copy link

Kerosel commented Oct 7, 2020

I came to the same conclusion today, so I'm happy to see someone else beat me to it. Wanted to write and point out that in the setup page there is a place to specify an invideo API server but when you change it, MusicPiped says to reload for the changes to take effect and when you reload, it goes back to invidio.us... might be something someone could poke at down the road.

I might also get ambitious and see if I can set up a build environment and build with your changes, see if it works.

@nchristensen
Copy link
Author

Yeah, I noticed that too. Sbado in #131 may have found the source of that problem.

@deep-gaurav deep-gaurav merged commit ebdcc2c into deep-gaurav:master Oct 7, 2020
@deep-gaurav
Copy link
Owner

Thanks,
Sorry for no reply on this project since a long time, I don't have much time to work on this, and didn't noticed that invidio.us is going to change.
I'll do some refactoring and fixes this weekend.
Will also add RustyPipe as another client side backend, since dart now has a good compatibility with dart ffi,

Kerosel pushed a commit to Kerosel/MusicPiped that referenced this pull request Oct 12, 2020
* Clean up API URL storage key mis-match. Now properly pulls URL entered
in preferences (originally commented by Sbado in deep-gaurav#136) Note that URL in
preferences MUST END WITH A SLASH (may sanitize this later)
* Make default API site invidious.xyz
* Change hardcoded site URLs in search to use URL stored in preferences
(other areas in search and main were already using it)

Tested working in a debug build on my Galaxy S7! ^_^

P.S. I had to release the version lock on cached_network_image to get it
to compile on my system. Hopefully this doesn't cause issues for anyone
else.
Kerosel pushed a commit to Kerosel/MusicPiped that referenced this pull request Oct 12, 2020
* Clean up API URL storage key mis-match. Now properly pulls URL entered
in preferences (originally commented by Sbado in deep-gaurav#136) Note that URL in
preferences MUST END WITH A SLASH (may sanitize this later)
* Make default API site invidious.xyz
* Change hardcoded site URLs in search to use URL stored in preferences
(other areas in search and main were already using it)

Tested working in a debug build on my Galaxy S7! ^_^

P.S. I had to release the version lock on cached_network_image to get it
to compile on my system. Hopefully this doesn't cause issues for anyone
else.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants