-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump pyright to 1.1.391 #2316
Conversation
📝 WalkthroughWalkthroughThe pull request updates the GitHub Actions workflow configuration for Pyright type checking. The changes involve upgrading the Python version from 3.10 to 3.12 and updating the Pyright action version from 1.1.363 to 1.1.391. These modifications ensure the type-checking workflow uses the latest Python version and the most recent Pyright action. Changes
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/pyright.yml (1)
Line range hint
19-19
: Consider pinning the checkout action version.Using
actions/checkout@master
could lead to unexpected behavior if breaking changes are introduced. Consider pinning to a specific version likeactions/checkout@v4
for better stability.- - uses: actions/checkout@master + - uses: actions/checkout@v4
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/pyright.yml
(1 hunks)
🔇 Additional comments (2)
.github/workflows/pyright.yml (2)
23-23
: LGTM! Python 3.12 upgrade is a good choice.
The upgrade to Python 3.12 brings improved type checking capabilities and performance improvements.
28-28
: LGTM! Pyright version bump looks good.
The minor version bump from 1.1.363 to 1.1.391 should be backward compatible while bringing the latest improvements and bug fixes.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2316 +/- ##
==========================================
- Coverage 96.19% 95.80% -0.39%
==========================================
Files 17 17
Lines 1418 1454 +36
==========================================
+ Hits 1364 1393 +29
- Misses 54 61 +7 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #2316 will not alter performanceComparing Summary
|
ec3ccff
Summary by CodeRabbit
pyright-action
version to 1.1.391 for improved compatibility.