feat: Snowflake connection params & permissions check update #1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
integration:snowflake
type:documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Additional Snowflake Connection Parameters #1179
Snowflake permissions check too restrictive #1181
Proposed Changes:
Added PrivateKey and PrivateKeyPwd parameters to allow more secure connection methodologies.
Added an additional role parameter and altered the check permissions logic to ensure the role/user has SELECT access, rather than read-only select access.
How did you test it?
Tested locally with dev branch using live Snowflake instance.
Notes for the reviewer
I've added the parameters which are commonly used (at least within our org), there is scope to add further params or custom connections. Happy to make future feature branches for this or discuss these changes further.