fix: Optimum - do not explictly pin transformers
#1303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anakin87
changed the title
transformers!=4.48.0transformers
Amnah199
pushed a commit
that referenced
this pull request
Jan 28, 2025
* pin transformers!=4.48.0 * lint * try removing explicit transformers dep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
transformers==4.48.0(Breaking change in v4.48.0 and Python 3.9 huggingface/transformers#35639)AttributeError: 'ORTModelForFeatureExtraction' object has no attribute 'input_names'. Did you mean: 'inputs_names'. I cannot reproduce it locally but only in the CI.transformerscauses strange dependency resolution. I also think we don't need that specific pin: it is already pinned by Optimum - see https://github.com/huggingface/optimum/blob/0a2b843ed4da48002e36d529fee5b1c607d6f301/setup.py#L51Proposed Changes:
transformersand letoptimumhandle the dependencyHow did you test it?
CI
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.