WeaviateDocumentStore initialization and serialization #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvanocerza
commented
Jan 10, 2024
Comment on lines
+148
to
+157
| def filter_documents(self, filters: Optional[Dict[str, Any]] = None) -> List[Document]: # noqa: ARG002 | ||
| return [] | ||
|
|
||
| def write_documents( | ||
| self, documents: List[Document], policy: DuplicatePolicy = DuplicatePolicy.NONE # noqa: ARG002 | ||
| ) -> int: | ||
| return 0 | ||
|
|
||
| def delete_documents(self, document_ids: List[str]) -> None: # noqa: ARG002 | ||
| return |
There was a problem hiding this comment.
ARG002 is ignored for the time being to let CI pass. In future PRs they'll be implement and the noqa removed.
ZanSara
reviewed
Jan 15, 2024
| @@ -46,6 +46,7 @@ git_describe_command = 'git describe --tags --match="integrations/weaviate-v[0-9 | |||
| dependencies = [ | |||
| "coverage[toml]>=6.5", | |||
| "pytest", | |||
| "ipython", | |||
There was a problem hiding this comment.
We need ipython as a dependency?
ZanSara
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #131
This PR implements a minimal initialization of
WeaviateDocumentStoreand the internal Weaviate client.It also adds proper serialization of the Document Store.
We also fix the
weaviate-clientversion to avoid breakages whenever the next upcoming version is released.