import triton files when triton is supported and installed #6989
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loadams
reviewed
Feb 3, 2025
| @@ -14,7 +14,7 @@ | |||
| from deepspeed.ops.transformer.inference.op_binding.workspace import WorkspaceOp | |||
| from deepspeed.accelerator import get_accelerator | |||
| import deepspeed | |||
| if deepspeed.HAS_TRITON: | |||
| if deepspeed.HAS_TRITON and get_accelerator().is_triton_supported(): | |||
There was a problem hiding this comment.
Is it worth cleaning up the HAS_TRITON flag if it isn't useful in this context, which it seems like it should have been.
loadams
approved these changes
Feb 3, 2025
|
@loadams some CI job is failing on this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those files have code that gets run when importing them, so in systems that doesn't support triton but have triton installed this causes issues.
In general, I think it is better to import triton when it is installed and supported.