Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor away from kubectl provider #53

Merged
merged 6 commits into from
Sep 6, 2023
Merged

refactor away from kubectl provider #53

merged 6 commits into from
Sep 6, 2023

Conversation

zack-is-cool
Copy link
Member

@zack-is-cool zack-is-cool commented Sep 5, 2023 •
edited
Loading

@zack-is-cool zack-is-cool requested a review from a team as a code owner September 5, 2023 22:01
@zack-is-cool zack-is-cool mentioned this pull request Sep 5, 2023
Closed
@zack-is-cool
Copy link
Member Author

zack-is-cool commented Sep 5, 2023 •
edited by narwhal-bot bot
Loading

/test all
🤖 View pipeline run

@zack-is-cool
Copy link
Member Author

zack-is-cool commented Sep 6, 2023 •
edited by narwhal-bot bot
Loading

/test all
🤖 View pipeline run

ntwkninja
ntwkninja previously approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@ntwkninja ntwkninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zack-is-cool
Copy link
Member Author

zack-is-cool commented Sep 6, 2023 •
edited by narwhal-bot bot
Loading

/test all
🤖 View pipeline run

@zack-is-cool
Copy link
Member Author

zack-is-cool commented Sep 6, 2023 •
edited
Loading

I added another var just to allow people to override the default eniconfig creation if they wanted to just make their own (not through the marketplace addon) for whatever reason

@zack-is-cool
Copy link
Member Author

zack-is-cool commented Sep 6, 2023 •
edited
Loading

/test e2e_govcloud_secure
updated pipeline to req a new token after the tests

@zack-is-cool
Copy link
Member Author

zack-is-cool commented Sep 6, 2023 •
edited by narwhal-bot bot
Loading

/test e2e_govcloud_secure
🤖 View pipeline run

ntwkninja
ntwkninja approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@ntwkninja ntwkninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@zack-is-cool zack-is-cool merged commit 1f44320 into main Sep 6, 2023
@zack-is-cool zack-is-cool deleted the bugfix/refactor-away-from-kubectl-provider branch September 6, 2023 20:24
@narwhal-bot narwhal-bot bot mentioned this pull request Sep 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntwkninja ntwkninja ntwkninja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug with gavinbunney/terraform-provider-kubectl + k8s 1.27
2 participants
@zack-is-cool @ntwkninja