Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update option for embeddings #48

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Add update option for embeddings #48

merged 2 commits into from
Nov 11, 2024

Conversation

NourOM02
Copy link

@NourOM02 NourOM02 commented Nov 8, 2024

I read on the readme file that if the changes happen to the database then new embeddings are required. However, the user should manually go and delete the old embeddings. Therefore I thought that adding an update paramter to the load_embeddings function can make the process more automatic.

Copy link
Member

@rishsriv rishsriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the helpful PR! :)

@NourOM02
Copy link
Author

NourOM02 commented Nov 8, 2024

The tests failed due to the sentence-transformers version conflicting with the huggingface-hub version (which is probably the latest since it isn't specified in the requirements file). The solution is to either upgrade the sentence-transformers package or downgrade the huggingface-hub package. I chose the first option and modified the requirements file. The tests run OK in my local machine.

Copy link
Member

@rishsriv rishsriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - much appreciated!

@rishsriv rishsriv merged commit f35d259 into defog-ai:main Nov 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants