added a method for creating an empty table, given metadata #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wongjingping
approved these changes
Jul 3, 2024
defog/admin_methods.py
Outdated
Comment on lines
306
to
307
| table_name = table_name.split(".")[-1] | ||
| schema_name = table_name.split(".")[0] |
There was a problem hiding this comment.
nit: we might want to limit the split to 1 in case there are multiple . present:
table_name.split(".", 1)[-1]
defog/admin_methods.py
Outdated
| """ | ||
| metadata = self.get_metadata(format="json", dev=dev) | ||
| if self.db_type == "sqlserver": | ||
| ddl = create_ddl_from_metadata(metadata, if_not_exists=False) |
There was a problem hiding this comment.
Seems like if_not_exists isn't defined as an argument for create_ddl_from_metadata - would this result in an error?
defog/admin_methods.py
Outdated
| else: | ||
| ddl = create_ddl_from_metadata(metadata) | ||
|
|
||
| if self.db_type == "postgres" or self.db_type == "redshift": |
There was a problem hiding this comment.
nit: do we want to wrap the code from here to the end below in a try/except block in case the metadata is malformed and can't be run? We can also just bubble common things like ImportError through.
|
Thank you for the suggestions! Fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful in situations where we have metadata that has been previously provided as - say - a CSV. With this, we can create empty tables that match the metadata, and test the model's performance.