Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic payment methods #24

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Dynamic payment methods #24

merged 3 commits into from
Jul 2, 2024

Conversation

tharindu-rhino
Copy link
Contributor

  • Be able to explicitly set the payment method(s) for purchase (e.g. Konbini only)
  • Be able to load all payment methods dynamically from the API with payment icons
  • Support card brand rendering for brands which are only enabled for the merchant via API
  • Localisation support in English, Japanese

@tharindu-rhino tharindu-rhino requested review from chathurapathiranage and kasunprabath98 and removed request for chathurapathiranage July 1, 2024 12:45
Copy link
Contributor

@kasunprabath98 kasunprabath98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tharindu-rhino ideally language should be passed from client app side
store the language in context (accept language as a string from client app side eg: "en")
and provide a method to change the language as well

example/services/sessionService.ts Outdated Show resolved Hide resolved
@tharindu-rhino
Copy link
Contributor Author

@tharindu-rhino ideally language should be passed from client app side store the language in context (accept language as a string from client app side eg: "en") and provide a method to change the language as well

@kasunprabath98 this option is provided. client can pass the language as a prop language={LanguageTypes.ENGLISH} under KomojuSDK.KomojuProvider if only this is not provided, will be taking the session default language

@tharindu-rhino tharindu-rhino merged commit 09745fb into dev Jul 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants