CBB-1170: remove param for source disable

deliveroo · Aug 27, 2024 · 2a0e432 · 2a0e432
1 parent 4c55d76
commit 2a0e432
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/aggs_metric.go b/aggs_metric.go
@@ -453,8 +453,8 @@ func (agg *TopHitsAgg) Sorts(sorts ...map[string]Sort) *TopHitsAgg {
 }
 
 // SourceDisabled when set will prevent source fields returning
-func (agg *TopHitsAgg) SourceDisabled(b bool) *TopHitsAgg {
-	agg.source.disabled = b
+func (agg *TopHitsAgg) SourceDisabled() *TopHitsAgg {
+	agg.source.disabled = true
 	return agg
 }
 

diff --git a/aggs_metric_test.go b/aggs_metric_test.go
@@ -204,7 +204,7 @@ func TestMetricAggs(t *testing.T) {
 						},
 					}...,
 				).
-				SourceDisabled(true),
+				SourceDisabled(),
 			map[string]interface{}{
 				"top_hits": map[string]interface{}{
 					"sort": []map[string]interface{}{

diff --git a/search.go b/search.go
@@ -91,8 +91,8 @@ func (req *SearchRequest) Timeout(dur time.Duration) *SearchRequest {
 }
 
 // SourceDisabled when set will prevent source fields returning
-func (req *SearchRequest) SourceDisabled(b bool) *SearchRequest {
-	req.source.disabled = b
+func (req *SearchRequest) SourceDisabled() *SearchRequest {
+	req.source.disabled = true
 	return req
 }
 

diff --git a/search_test.go b/search_test.go
@@ -26,7 +26,7 @@ func TestSearchMaps(t *testing.T) {
 		},
 		{
 			"a simple query with no source",
-			Search().SearchAfter("_id", "name").SourceDisabled(true),
+			Search().SearchAfter("_id", "name").SourceDisabled(),
 			map[string]interface{}{
 				"search_after": []string{"_id", "name"},
 				"_source":      false,