ESFF-2708: allow sorts to set multiple #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikesmitharoo
force-pushed
the
ESFF-2708/extend-sorts
branch
from
31df776 to
a9dfb1b
Compare
alekseizorin
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing sort function exposed by the os-query lib isn't very flexible (can't set multiple) and also isn't in the same pattern as the other components like aggs and queries.
This PR refactors the sort funcs for the top level query and the top hits aggs to allow a list of sorts to sent, this makes it easier for consuming apps to build a group of sorts in one hit.