Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable/cluster-overprovisioner] add chart #13

Merged
merged 19 commits into from
Aug 20, 2020

Conversation

mmingorance-dh
Copy link
Contributor

@mmingorance-dh mmingorance-dh commented Aug 19, 2020

Description

Add cluster-overprovisioner chart

Checklist

  • Title of the PR starts with chart name (e.g. [stable/mychartname])
  • Variables are documented in the README.md
  • Github actions are passing

@mmingorance-dh mmingorance-dh requested a review from a team as a code owner August 19, 2020 16:16
appVersion: "1.0"
description: Installs a deployment that overprovisions the cluster
name: cluster-overprovisioner
home: https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not correct

Copy link
Member

@max-rocket-internet max-rocket-internet Aug 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But maybe it's the most appropriate as there is "home" for this tool?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is wrong?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK maybe we just leave this as it is.

@mmingorance-dh mmingorance-dh requested a review from a team as a code owner August 19, 2020 20:51
Miguel Mingorance added 11 commits August 20, 2020 14:35
…clusters using Docker container 'nodes'

Usage:
  kind [command]

Available Commands:
  build       Build one of [node-image]
  completion  Output shell completion code for the specified shell (bash, zsh or fish)
  create      Creates one of [cluster]
  delete      Deletes one of [cluster]
  export      Exports one of [kubeconfig, logs]
  get         Gets one of [clusters, nodes, kubeconfig]
  help        Help about any command
  load        Loads images into nodes
  version     Prints the kind CLI version

Flags:
  -h, --help              help for kind
      --loglevel string   DEPRECATED: see -v instead
  -q, --quiet             silence all stderr output
  -v, --verbosity int32   info log verbosity
      --version           version for kind

Use "kind [command] --help" for more information about a command. cluster to succed
@mmingorance-dh mmingorance-dh force-pushed the add-cluster-overprovisioner branch from a30af96 to ef45576 Compare August 20, 2020 12:36
Copy link
Member

@max-rocket-internet max-rocket-internet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@mmingorance-dh mmingorance-dh merged commit 738d378 into master Aug 20, 2020
@mmingorance-dh mmingorance-dh deleted the add-cluster-overprovisioner branch August 20, 2020 14:03
@mmingorance-dh
Copy link
Contributor Author

helm-conftest deprecation tests have been disabled for cluster-overprivisoner due to this issue (instrumenta/helm-conftest#6). It will be reenabled once this problem is solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants