Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for fault sets to modules. #38

Merged
merged 35 commits into from
Feb 27, 2024

Conversation

ctronco
Copy link
Contributor

@ctronco ctronco commented Jan 22, 2024

Description

  • Adds fault_set_id|fault_set_name as a a parameter to dellemc.powerflex.sds
  • Add fault_set module dellemc.powerflex.fault_set
  • Add fault_set as a parameter to dellemc.powerflex.info

GitHub Issues

N/A

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, pep8, linting, or security issues
  • I have performed Ansible Sanity test using --docker default
  • I have verified that new and existing unit tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
This code was is a backport of code that's been in use by my team, but this code was tested in a lab environment.

  • Add Fault zone
  • Remove fault zone
  • Tested adding an sds with fault set specified

Copy link
Collaborator

@Bhavneet-Sharma Bhavneet-Sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the ansible_powerflex.log file.

Add the example fault_set.yml in _playbooks/modules/

galaxy.yml Outdated Show resolved Hide resolved
plugins/modules/fault_set.py Outdated Show resolved Hide resolved
plugins/modules/fault_set.py Outdated Show resolved Hide resolved
plugins/modules/fault_set.py Outdated Show resolved Hide resolved
plugins/modules/fault_set.py Outdated Show resolved Hide resolved
plugins/modules/fault_set.py Outdated Show resolved Hide resolved
plugins/modules/fault_set.py Outdated Show resolved Hide resolved
plugins/modules/fault_set.py Show resolved Hide resolved
plugins/modules/fault_set.py Outdated Show resolved Hide resolved
plugins/modules/fault_set.py Outdated Show resolved Hide resolved
@trisha-dell trisha-dell self-requested a review February 22, 2024 13:39
@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 92.77899% with 66 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@7d9eeda). Click here to learn what that means.

Files Patch % Lines
...dule_utils/storage/dell/libraries/configuration.py 58.00% 18 Missing and 3 partials ⚠️
plugins/modules/sds.py 91.17% 5 Missing and 13 partials ⚠️
plugins/modules/info.py 68.75% 6 Missing and 4 partials ⚠️
plugins/modules/fault_set.py 92.92% 4 Missing and 4 partials ⚠️
...gins/module_utils/libraries/powerflex_unit_base.py 84.00% 2 Missing and 2 partials ⚠️
...ule_utils/storage/dell/libraries/powerflex_base.py 82.35% 3 Missing ⚠️
...s/unit/plugins/module_utils/libraries/fail_json.py 80.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #38   +/-   ##
=======================================
  Coverage        ?   82.80%           
=======================================
  Files           ?       46           
  Lines           ?     5855           
  Branches        ?      791           
=======================================
  Hits            ?     4848           
  Misses          ?      742           
  Partials        ?      265           
Flag Coverage Δ
units 82.80% <92.77%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Bhavneet-Sharma Bhavneet-Sharma merged commit b85b7e4 into dell:main Feb 27, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants