Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating variable in capacity role #57

Merged

Conversation

Bhavneet-Sharma
Copy link
Contributor

@Bhavneet-Sharma Bhavneet-Sharma commented Jan 23, 2025

Description

Updating cap unit variable in capacity role.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, pep8, linting, or security issues
  • I have performed Ansible Sanity test using --docker default
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@ansible-collections-svc
Copy link
Collaborator

Can one of the admins verify this patch?

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.69%. Comparing base (b4fd7c6) to head (7dc960f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #57   +/-   ##
=======================================
  Coverage   54.69%   54.69%           
=======================================
  Files          31       31           
  Lines        3863     3863           
  Branches      580      580           
=======================================
  Hits         2113     2113           
  Misses       1548     1548           
  Partials      202      202           
Flag Coverage Δ
units 54.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Bhavneet-Sharma
Copy link
Contributor Author

run e2e

2 similar comments
@Bhavneet-Sharma
Copy link
Contributor Author

run e2e

@Bhavneet-Sharma
Copy link
Contributor Author

run e2e

@Bhavneet-Sharma Bhavneet-Sharma merged commit 237b0fe into dell:main Jan 23, 2025
24 checks passed
@Bhavneet-Sharma Bhavneet-Sharma deleted the bhavneet_sharma/capacity_role_fix branch January 23, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants