Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable version control metadata for unit tests #102

Merged
merged 39 commits into from
Dec 5, 2024

Conversation

atye
Copy link
Contributor

@atye atye commented Dec 5, 2024

Description

Set go flag to disable version control information when executing go list. If the version control information isn't available for whatever reason, go list will fail which breaks the excluded directories in the unit tests.

error obtaining VCS status: exit status 128
	Use -buildvcs=false to disable VCS stamping.

See https://github.com/dell/gopowerstore/actions/runs/12182452316/job/33993511339.

Issues

List the issues impacted by this PR:

Issue ID
dell/csm#1559

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

Checks pass in dell/gopowerstore#153.

@atye atye merged commit df6a9fc into main Dec 5, 2024
2 checks passed
@atye atye deleted the usr/atye/unit-test-exclude-dirs branch December 5, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants