-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added workflow to release csm libs #87
Conversation
Signed-off-by: Harish P <[email protected]>
Is this something we want to have to trigger manually in each repository? We could have a trigger action that will kick off the release in all the goclient libraries we have. Example of that is here: trigger workflow, target workflow |
@shaynafinocchiaro @gallacher If we try to release everything in one shot like the above example then we can't provide the versions to be released for different repos. So we can use this approach for only major release as per our discussions. |
Signed-off-by: Harish P <[email protected]>
Signed-off-by: Harish P <[email protected]>
Signed-off-by: Harish P <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@
@harishp8889 Based on our discussion, we decided the trigger workflow would only be used for minor releases because we can easily increment a minor release in a script. Major and patch releases will be manually kicked off per repository because patch don't fall within release cadence and major increments are determined by POs. This release workflow you've added is only for goclient libraries, so the trigger workflow will only be for go client libraries. We can add another trigger workflow for drivers/modules once we have the release workflow implemented. |
Description
Added automation to release process.
Issues
List the issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration