Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added workflow to release csm libs #87

Merged
merged 5 commits into from
Sep 25, 2024
Merged

Conversation

harishp8889
Copy link
Contributor

@harishp8889 harishp8889 commented Sep 23, 2024

Description

Added automation to release process.

Issues

List the issues impacted by this PR:

Issue ID
dell/csm#1490

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Tested by running automation against gobrick library by forking the repo.
image

donatwork
donatwork previously approved these changes Sep 24, 2024
.github/workflows/csm-release-libs.yaml Outdated Show resolved Hide resolved
.github/workflows/csm-release-libs.yaml Outdated Show resolved Hide resolved
.github/workflows/csm-release-libs.yaml Outdated Show resolved Hide resolved
.github/workflows/csm-release-libs.yaml Show resolved Hide resolved
@shaynafinocchiaro
Copy link
Contributor

Is this something we want to have to trigger manually in each repository? We could have a trigger action that will kick off the release in all the goclient libraries we have. Example of that is here: trigger workflow, target workflow

@harishp8889
Copy link
Contributor Author

harishp8889 commented Sep 25, 2024

Is this something we want to have to trigger manually in each repository? We could have a trigger action that will kick off the release in all the goclient libraries we have. Example of that is here: trigger workflow, target workflow

@shaynafinocchiaro @gallacher If we try to release everything in one shot like the above example then we can't provide the versions to be released for different repos. So we can use this approach for only major release as per our discussions.
Also we cannot trigger both libraries and drivers actions parallelly because we need to update the go.mod of drivers once all the libs are released.

Signed-off-by: Harish P <[email protected]>
Copy link

@prablr79 prablr79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shaynafinocchiaro
Copy link
Contributor

@

Is this something we want to have to trigger manually in each repository? We could have a trigger action that will kick off the release in all the goclient libraries we have. Example of that is here: trigger workflow, target workflow

@shaynafinocchiaro @gallacher If we try to release everything in one shot like the above example then we can't provide the versions to be released for different repos. So we can use this approach for only major release as per our discussions. Also we cannot trigger both libraries and drivers actions parallelly because we need to update the go.mod of drivers once all the libs are released.

@harishp8889 Based on our discussion, we decided the trigger workflow would only be used for minor releases because we can easily increment a minor release in a script. Major and patch releases will be manually kicked off per repository because patch don't fall within release cadence and major increments are determined by POs.

This release workflow you've added is only for goclient libraries, so the trigger workflow will only be for go client libraries. We can add another trigger workflow for drivers/modules once we have the release workflow implemented.

@harishp8889 harishp8889 merged commit 2f7cbb9 into main Sep 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants