Skip to content

Commit

Permalink
[Issue-1088] Adding logic to change drive status when health changed …
Browse files Browse the repository at this point in the history
…to bad
  • Loading branch information
kacper-michon committed Feb 20, 2024
1 parent d5847f2 commit 04127d7
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 0 deletions.
11 changes: 11 additions & 0 deletions pkg/node/volumemgr.go
Original file line number Diff line number Diff line change
Expand Up @@ -645,6 +645,7 @@ func (m *VolumeManager) updateDrivesCRs(ctx context.Context, drivesFromMgr []*ap
}
if value, ok := driveCR.GetAnnotations()[driveHealthOverrideAnnotation]; ok {
m.overrideDriveHealth(drivePtr, value, driveCR.Name)
m.overrideDriveStatusWhenHealthBad(drivePtr, value, driveCR.Name)
}
if driveCR.Equals(drivePtr) {
updates.AddNotChanged(&driveCR)
Expand Down Expand Up @@ -1316,6 +1317,16 @@ func (m *VolumeManager) overrideDriveHealth(drive *api.Drive, overriddenHealth,
}
}

// overrideDriveStatusWhenHealthBad replaces drive status to offline when health is being overidden to bad or unknown
func (m *VolumeManager) overrideDriveStatusWhenHealthBad(drive *api.Drive, overriddenHealth, driveCRName string) {
if (overriddenHealth == apiV1.HealthBad) ||
(overriddenHealth == apiV1.HealthUnknown) {
m.log.Warnf("Drive %s has health %s. Status is overridden with %s.",
driveCRName, drive.Health, apiV1.DriveStatusOffline)
drive.Status = apiV1.DriveStatusOffline
}
}

func (m *VolumeManager) setWbtValue(vol *volumecrd.Volume) error {
device, err := m.findDeviceName(vol)
if err != nil {
Expand Down
4 changes: 4 additions & 0 deletions pkg/node/volumemgr_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -831,6 +831,10 @@ func TestVolumeManager_updatesDrivesCRs_Success(t *testing.T) {
assert.Nil(t, vm.k8sClient.ReadCR(testCtx, drive.Name, "", actualDrive))
assert.Nil(t, err)
assert.Equal(t, actualDrive.Spec.Health, apiV1.HealthBad)

updatedDrive := &drivecrd.Drive{}
assert.Nil(t, vm.k8sClient.ReadCR(testCtx, drive.Name, "", updatedDrive))
assert.Equal(t, apiV1.DriveStatusOffline, updatedDrive.Spec.Status)
})

t.Run("new drive", func(t *testing.T) {
Expand Down

0 comments on commit 04127d7

Please sign in to comment.