Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue: 1070] Remove upper case from serial number #1075

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

katarzyna-kulpa
Copy link
Collaborator

Purpose

Resolves #1070

Do not alter serial disk number

PR checklist

  • Add link to the issue
  • Choose Project
  • Choose PR label
  • New unit tests added
  • Modified code has meaningful comments
  • All TODOs are linked with the issues
  • All comments are resolved

Testing

All regression tests

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7884f9a) 72.76% compared to head (4d788b0) 72.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1075   +/-   ##
=======================================
  Coverage   72.76%   72.76%           
=======================================
  Files          63       63           
  Lines        8949     8949           
=======================================
  Hits         6512     6512           
  Misses       2147     2147           
  Partials      290      290           
Flag Coverage Δ
unittests 72.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@katarzyna-kulpa katarzyna-kulpa merged commit 383d327 into master Jan 25, 2024
5 of 6 checks passed
@katarzyna-kulpa katarzyna-kulpa deleted the bugfix-issues-1070 branch January 25, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Hal lib
4 participants