Fix issue that GetVolumePath return a nil instead of error when can't get partition uuid #1078
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Resolves #
This is to resolve that an issue that GetVolumePath always return a nil when met error in getting partition stage.
we should return error if any error met in getting partition stage.
In RPC NodeStageVolume request, below code should return an err if GetVolumePath failed, this will then cause NodeStageVolume failure.
then Kubelet should retry this rpc again and again. This give the chance that driveCR updated success.
Changes:
this change fix an issue that a global err is defined, but we have another local err variable defined in a {} scope, so finally the global err always is nil.
Here we remove the retry for loop and always use the global err variable, as currently in search partition command, we already have a retry. so the retry here is not needed any more.
PR checklist
Testing
Provide test details