Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-1076] Fixing return error code for SearchPartName #1079

Merged
merged 4 commits into from
Feb 8, 2024

Conversation

Andrzej-Zukowski
Copy link
Collaborator

Purpose

Resolves #1077

Fix for error code returned in case of partition UUID not present on block device

PR checklist

  • Add link to the issue
  • Choose Project
  • Choose PR label
  • New unit tests added
  • Modified code has meaningful comments
  • All TODOs are linked with the issues
  • All comments are resolved

Testing

Provide test details

@Andrzej-Zukowski Andrzej-Zukowski force-pushed the bugfix-rc-volume-reconstruction-2 branch from 8df57af to 907c1f2 Compare February 7, 2024 13:43
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f45d675) 72.76% compared to head (e1a9a9f) 72.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1079      +/-   ##
==========================================
+ Coverage   72.76%   72.84%   +0.07%     
==========================================
  Files          63       63              
  Lines        8949     8949              
==========================================
+ Hits         6512     6519       +7     
+ Misses       2147     2142       -5     
+ Partials      290      288       -2     
Flag Coverage Δ
unittests 72.84% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@libzhang libzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the change looks good to me.

@Andrzej-Zukowski Andrzej-Zukowski merged commit bc5266f into master Feb 8, 2024
6 checks passed
@Andrzej-Zukowski Andrzej-Zukowski deleted the bugfix-rc-volume-reconstruction-2 branch February 8, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants