[ISSUE-1202]: Disk Eject E2E: RKE2 - Auto drive replacement - 2 or more volumes per pod #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdutka-dell
force-pushed
the
issue-1202
branch
29 times, most recently
from
3bf5a21 to
ca02bc9
Compare
|
|
katarzynakulpa
approved these changes
Jul 17, 2024
Signed-off-by: Malgorzata Dutka <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1213 +/- ##
==========================================
+ Coverage 71.04% 71.05% +0.01%
==========================================
Files 105 105
Lines 10592 10596 +4
==========================================
+ Hits 7525 7529 +4
Misses 2759 2759
Partials 308 308
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pawel-labuz
reviewed
Jul 19, 2024
| @@ -401,6 +402,7 @@ def wait_volume( | |||
| expected_status (Optional[str], optional): The expected status of the volume. Defaults to None. | |||
| expected_health (Optional[str], optional): The expected health of the volume. Defaults to None. | |||
| expected_usage (Optional[str], optional): The expected usage of the volume. Defaults to None. | |||
| expected_operational_status (Optional[str], optional): The expected operational status of the volume. Defaults to None. | |||
| timeout (int): The maximum time to wait for the volume in seconds. Defaults to 60. | |||
There was a problem hiding this comment.
It seems the default is 90 now
pawel-labuz
reviewed
Jul 19, 2024
| @@ -437,6 +442,7 @@ def wait_drive( | |||
| expected_status (Optional[str], optional): The expected status of the drive. Defaults to None. | |||
| expected_health (Optional[str], optional): The expected health of the drive. Defaults to None. | |||
| expected_usage (Optional[str], optional): The expected usage of the drive. Defaults to None. | |||
| expected_led_state (Optional[str], optional): The expected LED state of the drive. Defaults to None. | |||
| timeout (int): The maximum time to wait for the drive in seconds. Defaults to 60. | |||
pawel-labuz
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Resolves #1202
Automation of the scenario RKE2 - Auto drive replacement - 2 or more volumes per pod - SUCCESS
PR checklist
Testing
Provide test details