Merge pull request #279 from dell/fileStat

Improving file stat code
dell · Oct 13, 2023 · 56417e3 · 56417e3
2 parents 5cbcdba + 37aa4d0
commit 56417e3
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 3 deletions.
diff --git a/core/semver/semver.go b/core/semver/semver.go
@@ -307,8 +307,14 @@ var goarchToUname = map[string]string{
 }
 
 func fileExists(filePath string) bool {
-	if _, err := os.Stat(filePath); !os.IsNotExist(err) {
+	_, err := os.Stat(filePath)
+	if err == nil {
 		return true
 	}
+	if os.IsNotExist(err) {
+		fmt.Printf("File %s doesn't exist", filePath)
+	} else {
+		fmt.Printf("Found error %v while checking stat of file %s ", err, filePath)
+	}
 	return false
 }
diff --git a/pkg/node/node.go b/pkg/node/node.go
@@ -1650,8 +1650,19 @@ func (s *Service) buildInitiatorsArrayModify(initiators []string) []gopowerstore
 
 func (s *Service) fileExists(filename string) bool {
 	_, err := s.Fs.Stat(filename)
+	if err == nil {
+		return true
+	}
 	if os.IsNotExist(err) {
-		return false
+		log.WithFields(log.Fields{
+			"filename": filename,
+			"error":    err,
+		}).Error("File doesn't exist")
+	} else {
+		log.WithFields(log.Fields{
+			"filename": filename,
+			"error":    err,
+		}).Error("Error while checking stat of file")
 	}
-	return true
+	return false
 }