Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mountOptions not applied during node stage and expand volume #375

Merged
merged 8 commits into from
Nov 12, 2024

Conversation

AkshaySainiDell
Copy link
Contributor

@AkshaySainiDell AkshaySainiDell commented Nov 12, 2024

Description

Apply mountOptions during node stage volume and node expand volume

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1582

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Installed driver and then created SC, PVC and POD that uses mount options (nfsvers=4.1)

@adarsh-dell
Copy link
Contributor

Hi @AkshaySainiDell , Can you please add a screenshot of UT coverage?
Thanks

@AkshaySainiDell
Copy link
Contributor Author

Hi @AkshaySainiDell , Can you please add a screenshot of UT coverage? Thanks

UT results https://github.com/dell/csi-powerstore/actions/runs/11795706312/job/32855987013?pr=375
image

@suryagupta4 suryagupta4 merged commit 7231aff into main Nov 12, 2024
5 checks passed
@suryagupta4 suryagupta4 deleted the bugfix-1582-mountoptions branch November 12, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants