Multistage go build for docker image building #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KshitijaKakde
requested review from
abhi16394,
adarsh-dell,
AkshaySainiDell,
bharathsreekanth,
gallacher,
JacobGros,
jooseppi-luna,
mjsdell,
harishp8889 and
suryagupta4
as code owners
adarsh-dell
reviewed
Jan 22, 2024
Dockerfile
Outdated
| LABEL vendor="Dell Inc." \ | ||
| name="dellcsi-vg-snapshotter" \ | ||
| summary="CSI VG Snapshotter for Dell EMC Powerflex" \ | ||
| summary="CSI VG Snapshotter for Dell EMC PowerFlex" \ |
There was a problem hiding this comment.
@KshitijaKakde Since this is being used by both driver i.e. powerstore and powerflex, Can we add PoweFlex/PowerStore?
adarsh-dell
reviewed
Jan 22, 2024
|
|
||
| # set the REGISTRY if needed | ||
| ifeq ($(REGISTRY),) | ||
| export REGISTRY="$(DEFAULT_REGISTRY)" | ||
| endif | ||
|
|
||
| # set the GOVERSION if needed | ||
| ifeq ($(GOVERSION),) | ||
| export GOVERSION="$(DEFAULT_GOVERSION)" |
There was a problem hiding this comment.
@KshitijaKakde Could you kindly expand the overrides-help segment intended for the help page display? As we're introducing a new argument, it is advisable to incorporate it into the current list.
adarsh-dell
approved these changes
Jan 23, 2024
AkshaySainiDell
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Multistage go build for docker image building
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Build the docker image
Cert-csi vgs suite
