-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Observability updates 1.7.0 #873
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only powerscale and powermax are addressed . Other drivers doesn't require these changes ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you verify whether the generated values.yaml
is consistent with the samples file in csm-operator repository?
@@ -87,6 +87,7 @@ | |||
<select id="csm-version" class="form-select" onchange="onCSMVersionChange(); validateInput(validateForm, CONSTANTS)" required> | |||
<option value="1.7.0">CSM 1.7</option> | |||
<option value="1.8.0" selected>CSM 1.8</option> | |||
<option value="1.9.0">CSM 1.9</option> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you make this selected
instead of CSM 1.8.
forceRemoveDriver: true | ||
common: | ||
# Image for CSI PowerScale driver v2.8.0 | ||
image: "dellemc/csi-isilon:v2.8.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update all the driver version to v2.9.0 for xx1.9.0 templates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @chimanjain. Please make updates for platforms here
new PR #892 all comments were addressed . this PR pretty old , as lot conflicts if we try to merge |
new PR #892 all comments were addressed . this PR pretty old , as lot conflicts if we try to merge |
Description
Observability updates 1.7.0
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist: