Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observability updates 1.7.0 #873

Closed
wants to merge 4 commits into from

Conversation

HarishH-DELL
Copy link
Contributor

Description

Observability updates 1.7.0

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1012

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

Copy link

github-actions bot commented Nov 15, 2023

Test Results

76 tests   76 ✔️  3s ⏱️
  3 suites    0 💤
  1 files      0

Results for commit f2f5005.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@shefali-malhotra shefali-malhotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only powerscale and powermax are addressed . Other drivers doesn't require these changes ?

Copy link

@mareksuski-dell mareksuski-dell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good for me.

panigs7
panigs7 previously approved these changes Nov 16, 2023
Copy link
Contributor

@chimanjain chimanjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you verify whether the generated values.yaml is consistent with the samples file in csm-operator repository?

@@ -87,6 +87,7 @@
<select id="csm-version" class="form-select" onchange="onCSMVersionChange(); validateInput(validateForm, CONSTANTS)" required>
<option value="1.7.0">CSM 1.7</option>
<option value="1.8.0" selected>CSM 1.8</option>
<option value="1.9.0">CSM 1.9</option>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make this selected instead of CSM 1.8.

forceRemoveDriver: true
common:
# Image for CSI PowerScale driver v2.8.0
image: "dellemc/csi-isilon:v2.8.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update all the driver version to v2.9.0 for xx1.9.0 templates

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @chimanjain. Please make updates for platforms here

@HarishH-DELL
Copy link
Contributor Author

new PR #892 all comments were addressed . this PR pretty old , as lot conflicts if we try to merge

@HarishH-DELL
Copy link
Contributor Author

new PR #892 all comments were addressed . this PR pretty old , as lot conflicts if we try to merge

@shanmydell shanmydell deleted the observability-updates-1.7.0 branch December 14, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants