Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace CSI Operator References with CSM Operator #887

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

KerryKovacevic
Copy link
Contributor

Description

Replace CSI Operator references/links with CSM Operator.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#996

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

Copy link

github-actions bot commented Nov 21, 2023

Test Results

76 tests   76 ✔️  3s ⏱️
  3 suites    0 💤
  1 files      0

Results for commit bc82839.

♻️ This comment has been updated with latest results.

PeresKereotubo
PeresKereotubo previously approved these changes Nov 21, 2023
xuluna
xuluna previously approved these changes Nov 21, 2023
@@ -760,7 +760,7 @@ If such a node is not available, the pods stay in Pending state. This means they
Without storage capacity tracking, pods get scheduled on a node satisfying the topology constraints. If the required capacity is not available, volume attachment to the pods fails, and pods remain in ContainerCreating state. Storage capacity tracking eliminates unnecessary scheduling of pods when there is insufficient capacity.

The attribute `storageCapacity.enabled` in `my-powerstore-settings.yaml` can be used to enabled/disabled the feature during driver installation .
To configure how often driver checks for changed capacity set `storageCapacity.pollInterval` attribute. In case of driver installed via operator, this interval can be configured in the sample files provided [here](https://github.com/dell/dell-csi-operator/tree/master/samples) by editing the `capacity-poll-interval` argument present in the `provisioner` sidecar.
To configure how often driver checks for changed capacity set `storageCapacity.pollInterval` attribute. In case of driver installed via operator, this interval can be configured in the sample files provided [here](https://github.com/dell/csm-operator/tree/main/samples) by editing the `capacity-poll-interval` argument present in the `provisioner` sidecar.

**Note:**
>This feature requires kubernetes v1.24 and above and will be automatically disabled in lower version of kubernetes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessarily related to this PR but this note can be removed. For CSM 1.9 we only support 1.26, 1.27, and 1.28

gallacher
gallacher previously approved these changes Nov 21, 2023
Copy link
Contributor

@gallacher gallacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@shanmydell shanmydell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@shanmydell
Copy link
Collaborator

@KerryKovacevic : Please fix the liniting errors

@KerryKovacevic
Copy link
Contributor Author

@KerryKovacevic : Please fix the liniting errors

Lint error is part of a separate Installation Wizard issue that is known and being looked into by others.

@KerryKovacevic KerryKovacevic merged commit 7b44a3d into release-1.9.0 Nov 22, 2023
2 of 3 checks passed
@KerryKovacevic KerryKovacevic deleted the remove-csi-operator-references branch November 22, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants