Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PowerFlex: Added external access #913

Merged
merged 4 commits into from
Nov 30, 2023
Merged

PowerFlex: Added external access #913

merged 4 commits into from
Nov 30, 2023

Conversation

suryagupta4
Copy link
Contributor

Description

Added external access section in features page and externalAccess parameter in installation wizard template.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1011

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2023 •
edited
Loading

Test Results

76 tests   76 ✔️  3s ⏱️
  3 suites    0 💤
  1 files      0 ❌

Results for commit 710059e.

♻️ This comment has been updated with latest results.

gallacher
gallacher reviewed Nov 28, 2023
View reviewed changes
content/docs/csidriver/features/powerflex.md
@@ -907,6 +907,20 @@ allowedTopologies:
values:
- "true"
```
## Configuring custom access to NFS exports
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add 'externalAccess' here: https://dell.github.io/csm-docs/docs/csidriver/installation/helm/powerflex/#install-the-driver. Also, X_CSI_POWERFLEX_EXTERNAL_ACCESS to https://dell.github.io/csm-docs/docs/csidriver/installation/operator/powerflex/#install-driver.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@suryagupta4 suryagupta4 merged commit 911e3c7 into release-1.9.0 Nov 30, 2023
3 checks passed
@shanmydell shanmydell deleted the external-access-pflex branch December 14, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gallacher gallacher gallacher left review comments

@bharathsreekanth bharathsreekanth bharathsreekanth approved these changes

@KshitijaKakde KshitijaKakde KshitijaKakde approved these changes

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari is a code owner

@mareksuski-dell mareksuski-dell Awaiting requested review from mareksuski-dell

@mdutka-dell mdutka-dell Awaiting requested review from mdutka-dell

@mgandharva mgandharva Awaiting requested review from mgandharva mgandharva is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani rajkumar-palani is a code owner

@rsedlock1958 rsedlock1958 Awaiting requested review from rsedlock1958 rsedlock1958 is a code owner

@shanmydell shanmydell Awaiting requested review from shanmydell shanmydell is a code owner

@sharont58 sharont58 Awaiting requested review from sharont58 sharont58 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@suryagupta4 @gallacher @bharathsreekanth @KshitijaKakde