Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unrelevant information #915

Merged
merged 4 commits into from
Dec 7, 2023
Merged

Remove unrelevant information #915

merged 4 commits into from
Dec 7, 2023

Conversation

coulof
Copy link
Collaborator

@coulof coulof commented Nov 29, 2023

Description

In an effort to simplify our doc I removed some of the verbiage

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

@coulof
Remove unrelevant information
491a490 
In an effort to simplify our doc I removed some of the verbiage
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 29, 2023 •
edited
Loading

Test Results

76 tests   76 ✔️  3s ⏱️
  3 suites    0 💤
  1 files      0 ❌

Results for commit c1a064a.

♻️ This comment has been updated with latest results.

gallacher
gallacher previously approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@gallacher gallacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sharmilarama
Copy link
Contributor

Do we want to completely remove all the pages for partners or can we consolidate that into a simple list?

mareksuski-dell
mareksuski-dell previously approved these changes Dec 4, 2023
View reviewed changes
Copy link

@mareksuski-dell mareksuski-dell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but due to lack of long experiance with the CSM it is hard for me to validate if the "unrelevant information" was removed

@shanmydell shanmydell dismissed stale reviews from mareksuski-dell and gallacher via d5761d4 December 7, 2023 04:54
shanmydell
shanmydell previously approved these changes Dec 7, 2023
View reviewed changes
@coulof
Copy link
Collaborator Author

coulof commented Dec 7, 2023 •
edited
Loading

LGTM but due to lack of long experiance with the CSM it is hard for me to validate if the "unrelevant information" was removed

@sharmilarama & @mareksuski-dell The information was rather generic or redundant with what we have on the installation pages.

gallacher
gallacher approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@gallacher gallacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gallacher gallacher merged commit a01a7fc into release-1.9.0 Dec 7, 2023
3 checks passed
@gallacher gallacher deleted the simplify branch December 7, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gallacher gallacher gallacher approved these changes

@shanmydell shanmydell shanmydell approved these changes

@bharathsreekanth bharathsreekanth bharathsreekanth approved these changes

@mareksuski-dell mareksuski-dell mareksuski-dell left review comments

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari is a code owner

@mdutka-dell mdutka-dell Awaiting requested review from mdutka-dell

@mgandharva mgandharva Awaiting requested review from mgandharva mgandharva is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani rajkumar-palani is a code owner

@rsedlock1958 rsedlock1958 Awaiting requested review from rsedlock1958 rsedlock1958 is a code owner

@sharont58 sharont58 Awaiting requested review from sharont58 sharont58 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@coulof @sharmilarama @gallacher @shanmydell @bharathsreekanth @mareksuski-dell