Skip to content

Commit

Permalink
fixed make format issue
Browse files Browse the repository at this point in the history
Signed-off-by: shefali-malhotra <[email protected]>
  • Loading branch information
shefali-malhotra committed Oct 10, 2024
1 parent 75cb3f7 commit 6fde0e4
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 4 deletions.
4 changes: 4 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,10 @@ tag:
check:
./scripts/check.sh ./cmd/... ./opentelemetry/... ./internal/...

.PHONY: format
format:
@gofmt -w -s .

.PHONY: download-csm-common
download-csm-common:
curl -O -L https://raw.githubusercontent.com/dell/csm/main/config/csm-common.mk
1 change: 0 additions & 1 deletion internal/service/metrics_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1264,7 +1264,6 @@ func Test_FileSystem_Metrics_Label_Update(t *testing.T) {
t.Fatal(err)
}


meter.EXPECT().AsyncFloat64().Return(provider).Times(9)
provider.EXPECT().UpDownCounter(gomock.Any()).Return(readBW, nil)
provider.EXPECT().UpDownCounter(gomock.Any()).Return(writeBW, nil)
Expand Down
4 changes: 2 additions & 2 deletions internal/service/service.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ const (
// DefaultMaxPowerStoreConnections is the number of workers that can query powerstore at a time
DefaultMaxPowerStoreConnections = 10
// ExpectedVolumeHandleProperties is the number of properties that the VolumeHandle contains
ExpectedVolumeHandleProperties = 3
ExpectedVolumeHandleProperties = 3
// ExpectedVolumeHandleMetroProperties is the number of properties that the VolumeHandle of metro volumes contains
ExpectedVolumeHandleMetroProperties = 4
scsiProtocol = "scsi"
Expand Down Expand Up @@ -832,7 +832,7 @@ func (s *PowerStoreService) gatherFileSystemMetrics(ctx context.Context, volumes
volumeID = volumeProperties[0]
arrayID = volumeProperties[1]
protocol = volumeProperties[2]
// VolumeHandle is of the format "src-volume-id/array-ip/protocol:dest-volume-id/dest-array-ip"
// VolumeHandle is of the format "src-volume-id/array-ip/protocol:dest-volume-id/dest-array-ip"
} else if len(volumeProperties) == ExpectedVolumeHandleMetroProperties {
volumeID = volumeProperties[0]
arrayID = volumeProperties[1]
Expand Down
2 changes: 1 addition & 1 deletion internal/service/service_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -837,7 +837,7 @@ func Test_ExportFileSystemStatistics(t *testing.T) {
clients := make(map[string]service.PowerStoreClient)
c := mocks.NewMockPowerStoreClient(ctrl)
c.EXPECT().PerformanceMetricsByFileSystem(gomock.Any(), gomock.Any(), gomock.Any()).Times(1)
c.EXPECT().VolumeMirrorTransferRate(gomock.Any(),gomock.Any()).Times(1)
c.EXPECT().VolumeMirrorTransferRate(gomock.Any(), gomock.Any()).Times(1)
clients["127.0.0.1"] = c

service := service.PowerStoreService{
Expand Down

0 comments on commit 6fde0e4

Please sign in to comment.