Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifying image to use csm-base-image #688

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Conversation

eric-young
Copy link
Contributor

@eric-young eric-young commented Sep 12, 2024

Description

Converting csm-operator to use the common csm-base-image (which is based on ubi-micro) instead of the ubi micro image directly. This will speed up the image build process as well as allow building images on non RHEL nodes and building as a non root user.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1691

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • ran the Operator e2e tests (PowerStore) with the test Operator image.
    image
  • Built images as non root on non RHEL VM for all image build targets.

@eric-young
Copy link
Contributor Author

This PR depends upon the changes within https://github.com/dell/csm/tree/base-image-improvements, which is not yet ready for PR creation.

@tdawe tdawe force-pushed the use-csm-base-image branch 2 times, most recently from a76a4d3 to 2ef0489 Compare October 24, 2024 22:46
@donatwork
Copy link
Contributor

I ran the Operator e2e test for PowerStore and the changes work. Will open this PR for review once the csm changes are made.

@donatwork donatwork marked this pull request as ready for review January 24, 2025 23:03
Makefile Show resolved Hide resolved
Makefile Show resolved Hide resolved
@donatwork donatwork self-requested a review January 29, 2025 22:15
@donatwork donatwork requested a review from atye January 29, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants